Skip to content

Conversation

@klihub
Copy link
Contributor

@klihub klihub commented Nov 14, 2025

Bump OCI runtime tools and spec to v1.3.0.

Copy link
Contributor

@bart0sh bart0sh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @klihub

LGTM

Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
@klihub klihub force-pushed the devel/oci-runtime-spec-v1.3.0 branch from fb963c1 to 8ad6f3b Compare November 14, 2025 13:36
Copy link
Contributor

@elezar elezar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @klihub.

Is this something that we need to "backport" to the v1.0.0 spec, or are the changes on main such that we can go ahead and just release v1.0.1?

@elezar elezar merged commit 1b24d96 into cncf-tags:main Nov 14, 2025
8 checks passed
@klihub
Copy link
Contributor Author

klihub commented Nov 14, 2025

Thanks @klihub.

Is this something that we need to "backport" to the v1.0.0 spec, or are the changes on main such that we can go ahead and just release v1.0.1?

@elezar Hmm, I think we don't need to. The only reason for this dependency bump in CDI is to make the necessary OCI Spec bits for the pending Linux net device and RDT monitoring PRs (#269, #292) available to CDI, so we could kick those PRs forward at will.

Even in the (highly theoretical) case that some downstream CDI consumer wanted to make a new release with CDI 1.0.0 and opencontainer/runtime-spec 1.3.0, I'm not sure if we really were forced to do a backport. A locally unresolveable compilation failure would arise downstream if somehow because of us some golang package would be forced in with depending on pre-1.3.0 OCI Spec and someone in the compiled sources would reference LinuxPids.Limit in the Spec. Then we'd hit the int64 vs. *int64 snafu.

@AkihiroSuda
Copy link

Can we have a new git tag?

@klihub
Copy link
Contributor Author

klihub commented Nov 20, 2025

Can we have a new git tag?

@elezar @bart0sh @AkihiroSuda Before we do that it would be good to get #294 and #269 merged. And if we decide to go forward with #288, we could merge that, too.

@AkihiroSuda
Copy link

Can we have a new git tag?

@elezar @bart0sh @AkihiroSuda Before we do that it would be good to get #294 and #269 merged. And if we decide to go forward with #288, we could merge that, too.

@klihub Any chance to postpone unmerged PRs to vNextNext?

The release of containerd v2.2.1 is approaching, so it would be nice if we can have a tagged version of CDI (and NRI too: containerd/nri#243 (comment)) 🙏

@klihub
Copy link
Contributor Author

klihub commented Dec 10, 2025

Can we have a new git tag?

@elezar @bart0sh @AkihiroSuda Before we do that it would be good to get #294 and #269 merged. And if we decide to go forward with #288, we could merge that, too.

@klihub Any chance to postpone unmerged PRs to vNextNext?

The release of containerd v2.2.1 is approaching, so it would be nice if we can have a tagged version of CDI (and NRI too: containerd/nri#243 (comment)) 🙏

@AkihiroSuda We can definitely postpone merging pending functional PRs, but before tagging a 1.1.0 we need to fix a few inaccuracies that crept into the documentation, mostly related to recent changes for RDT. I have included the necessary changes in #269 (which was already approved for merging as such). We can either merge #269 with the additional changes or, if we want to keep the functional (Linux net device injection) changes out, we'll need to split out the doc adjusting changes to a new PR, then review and merge that separately.

@elezar WDYT ? Can you PTAL #269 and see if the doc fixes are good enough ?

@klihub
Copy link
Contributor Author

klihub commented Dec 10, 2025

@AkihiroSuda We merged what we could safely, fixed what we knew was off in the docs. And @elezar has already tagged the new v1.1.0 release. I'll file a PR to update containerd to use 1.1.0.

@AkihiroSuda
Copy link

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants