Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the
s3_endpointURL contains a path (e.g.https://s3.example.com/some/path) and S3 path-style access is used, s3 requests fail with a403 Forbiddendue to an incorrect AWSAWS4-HMAC-SHA256signature.With the above example endpoint, the current logic will:
hosttos3.example.com/some/pathpath/<bucket-name>/<requested-path>This PR corrects this to:
hosttos3.example.compath/some/path/<bucket-name>/<requested-path>Which fixes the downstream signature that is generated from those values.
An example of an S3-compatible endpoint that does this in practice is Supabase's Storage API, which serves the s3 endpoint from: