Skip to content

Fix s3 endpoint paths #2146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gregnr wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix s3 endpoint paths #2146

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
35ed4bb
fix: s3 endpoints with path
gregnr Dec 9, 2025
0f9748c
chore: remove incorrect tests
gregnr Dec 9, 2025
d820ff8
refactor: simplify s3 path fixes
gregnr Dec 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 14 additions & 7 deletions packages/duckdb-wasm/src/utils/s3_helper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,9 @@ export interface S3PayloadParams {

const getHTTPHost = function (config: S3Config | undefined, url: string, bucket: string): string {
if (config?.endpoint?.startsWith('http')) {
// Endpoint is a full url, we append the bucket
const httpHost = `${config?.endpoint}`;
const offset = httpHost.indexOf('://') + 3;
return httpHost.substring(offset);
// Endpoint is a full url, extract just the host (no path)
const endpointUrl = new URL(config.endpoint);
return endpointUrl.host;
} else if (config?.endpoint) {
// Endpoint is not a full url and the https://{bucket}.{domain} format will be used
return `${bucket}.${config?.endpoint}`;
Expand All @@ -38,12 +37,20 @@ const getHTTPHost = function (config: S3Config | undefined, url: string, bucket:
export function getS3Params(config: S3Config | undefined, url: string, method: string): S3Params {
const parsedS3Url = parseS3Url(url);

// when using S3 path-style access, the signed URL should also include the bucket name,
// as it is present in the HTTP URL path.
// when using S3 path-style access, the signed URL should also include the endpoint's path + bucket name,
// as they will both be present in the HTTP URL path.
// See: https://docs.aws.amazon.com/AmazonS3/latest/userguide/access-bucket-intro.html#path-style-url-ex
let path = parsedS3Url.path;
if (isPathStyleAccess(config)) {
path = `/${parsedS3Url.bucket}${path}`;
// Extract endpoint path if present (e.g., "/some/path" from "https://host/some/path")
let endpointPath = '';
if (config?.endpoint) {
const endpointUrl = new URL(config.endpoint);
if (endpointUrl.pathname !== '/') {
endpointPath = endpointUrl.pathname;
}
}
path = `${endpointPath}/${parsedS3Url.bucket}${path}`;
}
return {
url: path,
Expand Down