Skip to content

Conversation

@ym
Copy link
Contributor

@ym ym commented Nov 28, 2025

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes an issue where custom domain values were not being displayed in the network settings form. It also enhances backend domain handling to properly use DHCP-provided domain names in resolv.conf.

Key changes:

  • Modified UI to detect, store, and display custom domain values when loading network settings
  • Updated backend to pass DHCP lease domain information through to resolv.conf generation
  • Fixed domain selection logic to treat "dhcp" as a configuration option rather than a literal domain name

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
ui/src/routes/devices.$id.settings.network.tsx Adds logic to detect custom domains, store them in state, display them in the form input, and includes proper dependency tracking
pkg/nmlite/resolvconf.go Adds domain field to resolv.conf template execution and adds debug logging for nameserver/search list configuration
pkg/nmlite/interface.go Passes DHCP lease domain information to resolv.conf configuration
pkg/nmlite/hostname.go Updates getDomain() to treat "dhcp" as a sentinel value rather than a literal domain name

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@adamshiervani adamshiervani merged commit d996177 into dev Dec 8, 2025
12 checks passed
@adamshiervani adamshiervani deleted the fix/dhcp-domain branch December 8, 2025 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants