Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/nmlite/hostname.go
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ func (hm *ResolvConfManager) getHostname() string {
}

func (hm *ResolvConfManager) getDomain() string {
if hm.domain != "" {
if hm.domain != "" && hm.domain != "dhcp" {
return hm.domain
}

Expand Down
1 change: 1 addition & 0 deletions pkg/nmlite/interface.go
Original file line number Diff line number Diff line change
Expand Up @@ -787,6 +787,7 @@ func (im *InterfaceManager) updateStateFromDHCPLease(lease *types.DHCPLease) {
NameServers: lease.DNS,
SearchList: lease.SearchList,
Source: "dhcp",
Domain: lease.Domain,
}); err != nil {
im.logger.Warn().Err(err).Msg("failed to update resolv.conf")
}
Expand Down
6 changes: 6 additions & 0 deletions pkg/nmlite/resolvconf.go
Original file line number Diff line number Diff line change
Expand Up @@ -192,13 +192,19 @@ func (rcm *ResolvConfManager) generateResolvConf(conf *types.ResolvConf) ([]byte
mergeConfig(&nameservers, &searchList, &conf.ConfigIPv4)
mergeConfig(&nameservers, &searchList, &conf.ConfigIPv6)

rcm.logger.Info().
Interface("nameservers", nameservers).
Interface("searchList", searchList).
Msg("merged config")

flattenedSearchList := []string{}
for search := range searchList {
flattenedSearchList = append(flattenedSearchList, search)
}

var buf bytes.Buffer
if err := tmpl.Execute(&buf, map[string]any{
"domain": rcm.getDomain(),
"nameservers": nameservers,
"searchList": flattenedSearchList,
}); err != nil {
Expand Down
10 changes: 9 additions & 1 deletion ui/src/routes/devices.$id.settings.network.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,8 @@ export function LifeTimeLabel({ lifetime }: Readonly<{ lifetime: string }>) {
);
}

const NonCustomDomainOptions = ["dhcp", "local"];

export default function SettingsNetworkRoute() {
const { send } = useJsonRpc();

Expand Down Expand Up @@ -128,13 +130,18 @@ export default function SettingsNetworkRoute() {
},
};

if (!NonCustomDomainOptions.includes(settingsWithDefaults.domain)) {
setCustomDomain(settingsWithDefaults.domain);
settingsWithDefaults.domain = "custom";
}

initialSettingsRef.current = settingsWithDefaults;
return { settings: settingsWithDefaults, state };
} catch (err) {
notifications.error(m.network_settings_load_error({ error: err instanceof Error ? err.message : m.unknown_error() }));
throw err;
}
}, [setNetworkState]);
}, [setNetworkState, setCustomDomain]);

const formMethods = useForm<NetworkSettings>({
mode: "onBlur",
Expand Down Expand Up @@ -406,6 +413,7 @@ export default function SettingsNetworkRoute() {
type="text"
label={m.network_custom_domain()}
placeholder="home.example.com"
value={customDomain}
onChange={e => {
setCustomDomain(e.target.value);
}}
Expand Down