Skip to content

Disable f16 on LoongArch for LLVM < 21 #150336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
heiher wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Disable f16 on LoongArch for LLVM < 21 #150336

heiher wants to merge 1 commit into from
+1 −0

Conversation

@heiher
Copy link
Contributor

@heiher heiher commented Dec 24, 2025

The f16 type works on the LoongArch target starting from LLVM 21. However, the current minimum supported external LLVM version is 20, so f16 must not be enabled on LoongArch for LLVM version < 21.

@heiher
Disable f16 on LoongArch for LLVM < 21
855281c 
The `f16` type works on the LoongArch target starting from LLVM 21.
However, the current minimum supported external LLVM version is 20,
so `f16` must not be enabled on LoongArch for LLVM version < 21.
@rustbot rustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 24, 2025
@rustbot
Copy link
Collaborator

rustbot commented Dec 24, 2025

r? @jackh726

rustbot has assigned @jackh726.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@lqd
Copy link
Member

lqd commented Dec 24, 2025

Thanks! I don't believe this would run on CI, but if so r=me when green.

r? lqd

@rustbot rustbot assigned lqd and unassigned jackh726 Dec 24, 2025
@lqd
Copy link
Member

lqd commented Dec 24, 2025

@bors r+

@bors
Copy link
Collaborator

bors commented Dec 24, 2025

📌 Commit 855281c has been approved by lqd

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 24, 2025
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Dec 24, 2025
@JonathanBrouwer
Rollup merge of rust-lang#150336 - heiher:loong-no-f16-llvm20, r=lqd
c97b319 
Disable f16 on LoongArch for LLVM < 21

The `f16` type works on the LoongArch target starting from LLVM 21. However, the current minimum supported external LLVM version is 20, so `f16` must not be enabled on LoongArch for LLVM version < 21.
@JonathanBrouwer JonathanBrouwer mentioned this pull request Dec 24, 2025
Closed
bors added a commit that referenced this pull request Dec 24, 2025
@bors
Auto merge of #150340 - JonathanBrouwer:rollup-t607w60, r=JonathanBro…
9777739 
…uwer

Rollup of 2 pull requests

Successful merges:

 - #150311 (Avoid using env::temp when linking a binary)
 - #150336 (Disable f16 on LoongArch for LLVM < 21)

r? `@ghost`
`@rustbot` modify labels: rollup
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Dec 24, 2025
@JonathanBrouwer
Rollup merge of rust-lang#150336 - heiher:loong-no-f16-llvm20, r=lqd
cba038f 
Disable f16 on LoongArch for LLVM < 21

The `f16` type works on the LoongArch target starting from LLVM 21. However, the current minimum supported external LLVM version is 20, so `f16` must not be enabled on LoongArch for LLVM version < 21.
@JonathanBrouwer JonathanBrouwer mentioned this pull request Dec 24, 2025
Closed
bors added a commit that referenced this pull request Dec 24, 2025
@bors
Auto merge of #150342 - JonathanBrouwer:rollup-r5g9by1, r=JonathanBro…
8bdb7d3 
…uwer

Rollup of 4 pull requests

Successful merges:

 - #150311 (Avoid using env::temp when linking a binary)
 - #150336 (Disable f16 on LoongArch for LLVM < 21)
 - #150338 (Include rustc version in ICE messages)
 - #150341 (Fix some divergences with the cg_clif subtree)

r? `@ghost`
`@rustbot` modify labels: rollup
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Dec 24, 2025
@JonathanBrouwer
Rollup merge of rust-lang#150336 - heiher:loong-no-f16-llvm20, r=lqd
2622cc2 
Disable f16 on LoongArch for LLVM < 21

The `f16` type works on the LoongArch target starting from LLVM 21. However, the current minimum supported external LLVM version is 20, so `f16` must not be enabled on LoongArch for LLVM version < 21.
@JonathanBrouwer JonathanBrouwer mentioned this pull request Dec 24, 2025
Open
bors added a commit that referenced this pull request Dec 24, 2025
@bors
Auto merge of #150343 - JonathanBrouwer:rollup-1mwkrdv, r=JonathanBro…
24ac030 
…uwer

Rollup of 3 pull requests

Successful merges:

 - #150311 (Avoid using env::temp when linking a binary)
 - #150336 (Disable f16 on LoongArch for LLVM < 21)
 - #150338 (Include rustc version in ICE messages)

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@lqd lqd

Labels

A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@heiher @rustbot @lqd @bors @jackh726