Skip to content

Conversation

@nightkr
Copy link
Contributor

@nightkr nightkr commented Nov 29, 2024

Mostly copied from operator-rs. Would be nice to have this managed by operator-templating, but that depends on stackabletech/operator-templating#80.

See #11.

Mostly copied from operator-rs. Would be nice to have this managed by
operator-templating, but that depends on
stackabletech/operator-templating#80.
@nightkr
Copy link
Contributor Author

nightkr commented Nov 29, 2024

The remaining pre-commit failures are from issues in the common files, so we should probably address those upstream instead...

Doing a followup PR to address the cargo deny failures.

@nightkr nightkr requested a review from a team November 29, 2024 14:29
@nightkr
Copy link
Contributor Author

nightkr commented Dec 9, 2024

The remaining deny failures (from users) are addressed in #13.

@nightkr nightkr mentioned this pull request Dec 9, 2024
razvan
razvan previously approved these changes Dec 9, 2024
Copy link
Member

@razvan razvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Co-authored-by: Razvan-Daniel Mihai <84674+razvan@users.noreply.github.com>
@nightkr nightkr requested a review from razvan December 9, 2024 10:34
@nightkr nightkr enabled auto-merge December 9, 2024 10:40
@nightkr nightkr added this pull request to the merge queue Dec 9, 2024
Merged via the queue into main with commit 24c805d Dec 9, 2024
8 of 10 checks passed
@nightkr nightkr deleted the feature/ci branch December 9, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants