Drop unmaintained users dependency #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mostly copied from operator-rs. Would be nice to have this managed by operator-templating, but that depends on stackabletech/operator-templating#80.
It's unmaintained, has open vulnerabilities, and is redundant with sysinfo which we already use.
razvan
approved these changes
Dec 9, 2024
Member
razvan
left a comment
razvan
left a comment
There was a problem hiding this comment.
I just noticed that it lacks a changelog which maybe we want after the first release.
Otherwise it lgtm!
Contributor
Author
|
Yep, #14 adds one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's unmaintained, has open vulnerabilities, and is redundant with sysinfo which we already use.
Stacked PR on top of #12.